-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parse Relation not working #404
base: master
Are you sure you want to change the base?
Conversation
Did some general enhancements on the code structure it's more consistent (Working on `object` types are cool but a pain to debug since you never know the real type until you hit an exception.) I tried to make it so the code is more readable as well. Closes #397
Thanks for opening this pull request! |
this should be 2nd to be approved |
Should work good
You mentioned in the PR title only Parse Relations. But according to the description this PR closes 3 bugs; which one is true? |
@mtrezza they are all fixed ! This sample repo of mine showcases most if not all the basic/core Parse operations + having Parse Live Queries methods too for anyone in need of a Demo. Those issues we caused by encoding, like with User, operations (and querying) The demo is extremely simple. |
Nice, but how is it possible that the CI passes here even before we merged #403? |
Because Like I said, the main issues were very like likely linked to either encoding or the way we received Https responses. So fixing "Encoding" likely provided a stable foundation for all Https Enc/Decoding. That's my thought process at least. |
So they likely pass because Relations didn't have methods implemented AND didn't have test implemented to test coverage. |
In anticipation to any other questions let me fully explain the changes I made...;
These are the highlights. any other change was just to ensure field operations work as they should. |
Could you please take a look at the conflicts so we can review this? Seems to be just minor formatting. |
Did remove dup assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I've mentioned in #404 (comment) this PR contains a lot of unrelated formatting changes like indentation, spaces, newline. This makes the PR more difficult to review. Some of these changes are likely done manually, other may be done automatically by your IDE. Since we don't have a linter yet, we'll make an exception and ignore these changes in this PR, so we can go ahead faster. However, to make PRs easier to review, could you please make sure that a PR doesn't contain such changes? Just take a look at the changes before you the commit. If you see any unnecessary line changes, please revert them before committing. You can also see these changes on GitHub in the "Files changed" tab. I've opened #406 to add a linter, which will prevent these changes to get merged in the future, but it's still in the works.
Sure thing. I'll be more diligent on that aspect. Adding the linter will help indeed, as sometimes the file changes don't even reflect on my end. But all is good now. Next PR should be easier to Navigate through |
Thank you. Before I merge, could you please suggest a title for this PR that describes all the things that this PR fixes? The #397 seems quite broad as it mentions 3 problems in #397 (comment) and in #397 (comment) you mention that it "clears your issues and any other potential one" so this PR fixes more than the 3 issues? If yes, what are these other issues? Or do all these issues have a common, underlying bug that has been fixed? This is quite confusing. |
Sure.
That's pretty much it. everything else is unchanged (unless I haven't caught it/if it's an issue!) Just ONE change I want to do later and it will be to REPLACE this below. It doesn't negatively affect At all. but it will always print out "Unsupported length" all the time as an exception. I have the fix already but will hold on to that, perhaps in the next PR - depends on you I suppose.
|
Are all these points 1-7 related to the bug with Parse Relations? Or are these actually 7 individual bugs? Or are some of these not bugs but new features or perhaps performance optimizations? And are any of these points breaking changes? |
|
I don't follow. I was asking whether these points are related to the issue with Parse Relation and you say they are all related to encoding/decoding. So how is encoding/decoding related to the bug with Parse Relation? I also don't understand: "None of the bugs here are new since Parse supported the features before." What features are you referring to? So this PR does fix other bugs besides the Parse Relation bug? For example, how are points 1 or 4 related to Parse Relation, they sound like completely different bugs? Point 6 sounds like a breaking change since it's a name change of a public method? And how is that required to fix the Parse Relation bug? Note that the only accepted way to demonstrate that something does not break is a unit test that passes before and after the change. If that unit test doesn't exist already, it needs to be added as part of the PR. If you prefer, I believe we may resolve all these questions quicker in a chat. Feel free to join our community chat and ping me there. |
Closes: #397
Did some general enhancements on the code structure it's more consistent (Working on
object
types are cool but a pain to debug since you never know the real type until you hit an exception.)